Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI setup adding the staging server #155

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Conversation

javier-tarazaga
Copy link
Contributor

@javier-tarazaga javier-tarazaga commented Nov 19, 2019

Description of the Change

Changed the CI configuration to add an in-between step for first deploying to staging server before actually releasing it to production.

Looking at the CI changes, you will notice we have divided it into 4 stages.

  1. Build the staging version of the app
  2. Deploy to the staging cluster
  3. Build the release version of the app
  4. Deploy to the production cluster

We have set up a couple of flags for the prod deployment routine:

  • Added the when: manual prop to the job in order to make sure the production deployment only can be executed manually.
  • Added the allowFailure: false, this will enforce the requirement of only running the deploy to prod stage once the build prod actually succeeds.

Additionally, I have updated all env variables in the Superblocks CI to be able to match everything.

Benefits

Having a staging environment to test stuff in a live environment before actually deploying to production.

Copy link
Contributor

@filippsen filippsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Renaming dev build (development) to staging
    OK

  • Rename .env.development file
    OK

  • Update .env.development file
    Requires studio-api-staging to be set.
    OK

  • Modify superblocks.yaml to add staging step
    Depends on environment variables set.
    Apparently similar to previously set environment.
    OK

  • Modify superblocks.yaml to only build to production when running the manual job
    OK

  • Removed .env.development.local in favor of .env.local
    Related issue: Errors setting up local development #25

@javier-tarazaga javier-tarazaga merged commit 1c1968e into master Nov 19, 2019
@javier-tarazaga javier-tarazaga deleted the update-ci-spec branch March 30, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants