Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Escape 'complex characters' characters in SurrealThing Key #29

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Escape 'complex characters' characters in SurrealThing Key #29

merged 2 commits into from
Sep 19, 2022

Conversation

Du-z
Copy link
Collaborator

@Du-z Du-z commented Sep 19, 2022

Copy link
Collaborator

@ProphetLamb ProphetLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The logic looks sound. Thought I am going to move the escaping to the JsonConverter for the struct, because C# doesnt need escaping, it is required by SurrealDB.
It might confuse a user to have their content changed when creating this struct, that is intended as a string wrapper with extra info. Not to mention, we can reformat lazily in the serializer, and have much less overhead that way

@Du-z
Copy link
Collaborator Author

Du-z commented Sep 19, 2022

yeah, no problem. sounds like a plan.

@ProphetLamb ProphetLamb merged commit 662b7eb into Surreal-Net:master Sep 19, 2022
@Du-z Du-z deleted the escape_complex_characters_in_keys branch September 21, 2022 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants