-
Notifications
You must be signed in to change notification settings - Fork 7
Added support and tests for multiple result sets #88
Conversation
Includes a massive simplification of result handling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. The external API is looking good, but internally the IResponse
implementations should not contain pointer arrays. I suggest storing RawResult
instead, for the following reasons:
- Less initial overhead because of Lazy behaviour
- SoC for Response vs Result
- While multiple enumeration is possible, the conversion overhead is minimal.
- No boxing of value types
I suspect creating the OkResult
s and ErrorResult
s of a Response at least twice is still faster than n+1
GC allocs and subsequent GC destroys
Not quite sure of the implementation details you are asking for. Is this this change what you are looking for 2353e79 . It is deferring the deserialization of the results for as long as possible, and in some cases skip deserialization all together. Feel free to tweak and merge if you wish. |
Move functions loosely related to DriverResponse to ResponseExtensions.
No description provided.