Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Added tests and fixes for times with fractions with more than 7 digits #98

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Added tests and fixes for times with fractions with more than 7 digits #98

merged 1 commit into from
Oct 16, 2022

Conversation

Du-z
Copy link
Collaborator

@Du-z Du-z commented Oct 16, 2022 •
edited
Loading

The following DateTime was failing to parse

2022-10-16T05:57:32.329470400Z

Added fix and tests

@Du-z
Copy link
Collaborator Author

Du-z commented Oct 16, 2022

@ProphetLamb Is it possible to change the default branch to be develop? it would be easy to accidentally make PR going into master.

ProphetLamb
ProphetLamb approved these changes Oct 16, 2022
View reviewed changes
Copy link
Collaborator

@ProphetLamb ProphetLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot!

@ProphetLamb ProphetLamb merged commit 320b5c4 into develop Oct 16, 2022
@ProphetLamb ProphetLamb deleted the feature/times_with_ns_precision branch October 16, 2022 13:12
@ProphetLamb ProphetLamb mentioned this pull request Oct 16, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ProphetLamb ProphetLamb ProphetLamb approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Du-z @ProphetLamb