Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config autodownload #62

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Update config autodownload #62

merged 3 commits into from
Oct 30, 2023

Conversation

vodkapmp
Copy link
Contributor

@vodkapmp vodkapmp commented Oct 30, 2023

This should work for the new missing settings.
These changes allow for these variables to be modified for people running this docker container, which is currently not possible as they're overwritten on startup.

This closes #55

@vodkapmp
Copy link
Contributor Author

@Syer10 The checks fail as they use the .secrets from my repository, I've set those up now so the checks should work.

The only issue is that the workflow is set to push the image to the image repo for Suwayomi/docker-tachidesk, and wont work with forks without changing the workflows.
I could do this but I'd need some more time to get that sorted.

@Syer10
Copy link
Contributor

Syer10 commented Oct 30, 2023

No problem. I will merge without the checks then, the code looks fine and I don't see any issues so it should build fine.

@Syer10 Syer10 merged commit 2f09862 into Suwayomi:main Oct 30, 2023
1 check failed
@vodkapmp vodkapmp deleted the update-config-autodownload branch October 31, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Create new environment variables for new config file options in starting from preview v0.7.0-r1369
2 participants