Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Proper "View Images in Gallery" Button Functionality #1088

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SamithaKosanam
Copy link

Description

After extracting image(s) from a PDF, the "View Images in Gallery" button would fail to actually show the extracted images in the Gallery. This change makes this button functional by putting the correct image content in the URI, which was done by building on a previous pull request that made acceptable changes to the ImageUtils.java file, but this change also adds changes to the FileUtils.java file, as well as the PdfToImageFragment.java file.

Fixes #1058

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented Oct 3, 2022

Code Climate has analyzed commit 8bf09a8 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Copy link
Owner

@Swati4star Swati4star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the merge conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In PDF to Images function, feature "View Images in Gallery" could not show generated images in gallery.
2 participants