Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support rollup v3 #227

Closed
wants to merge 1 commit into from
Closed

feat!: support rollup v3 #227

wants to merge 1 commit into from

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Oct 13, 2022

Resolves #226

  • Update transform outputOptions for v3 compatibility
  • Update rollup peerDependency to 3.0.0 (options API is changed)
  • Add json assertion to package.json import

@pi0 pi0 mentioned this pull request Oct 13, 2022
src/transform/index.ts Show resolved Hide resolved
@Swatinem
Copy link
Owner

CI is not too happy. It needs to bump the lower node version. Also there is a bunch of snapshot changes, but those seem to be related to some more comments in the output. I can check all that stuff maybe on the weekend.

@Mister-Hope
Copy link
Contributor

Mister-Hope commented Oct 14, 2022

Btw, can we add tests for 14 and 16? That may perform a more accurate result.Also Node 12 should be dropped

@SukkaW
Copy link

SukkaW commented Oct 14, 2022

CI is not too happy. It needs to bump the lower node version.

Rollup has bumped the minimum required Node.js version to 14 as part of its breaking changes.

If rollup-plugin-dts is going to adopt this change, a new major version has to be released.

@Swatinem
Copy link
Owner

I manually merged this, fixed up all the tests, and bumped the minimum supported rollup and node versions.

can we add tests for 14 and 16?

I rather just want to test with latest node and minimum supported, I don’t think testing intermediate versions provides any value.

I will publish a new major in the coming days.

@Swatinem Swatinem closed this Oct 14, 2022
@pi0 pi0 deleted the feat/rollup3 branch October 15, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup v3 support
4 participants