test: "export const" in .ts module

[aleclarson]

This test fails with the following output:

- /// <reference types="react" />
- declare type JSXElements = keyof JSX.IntrinsicElements;
- declare const elements: JSXElements[];
+ export declare type JSXElements  JSX.IntrinsicElements;
+ export declare const elements: Jnts[];
  export { JSXElements, elements };

[aleclarson]

Looks like two bugs with one stone!

• Use input.getFullText instead of input.getText (which omits "comment pragmas")
  (fixed in 936446a)

• Rollup omits comment pragmas, because they use // syntax
  (not fixed yet, but I opened this: Preserve triple backslash comments or add new option for preserving comments based on regex rollup/rollup#2943)

[aleclarson]

Hmm, looks like we'll need to prepend the removed comment pragmas post hoc.

Preserving certain comments would be a non-trivial change, especially since by default, acorn does not help us at all in associating comments with Nodes so everything needs to be done by hand.

[aleclarson]

Alright, the test is passing now! 🎉

With ca5ba31, any reference directives are collected in the transformFile function, and then they're re-added during the renderChunk step.

[Swatinem]

Some coding style suggestions.
Plus, I would very much prefer to use the properties which are defined in the TS API instead of manually typing things.
I will most likely only look at those things tomorrow on my work machine.

[Swatinem]

I don’t really have a better idea right now, just keep in mind that introducing more global state makes it harder to fix watch mode (#35)

[Swatinem]

since you check this here, is your type declaration really correct? (nullability?)
Also, your manual type declaration plus the as any cast suggests that this is not officially documented TS API?

A quick check with https://astexplorer.net/#/gist/577600e28bd89938dc16f5bf445980d4/0213bb7d7515552ab575dabaec61561145080b5d showed me that the sourceFile has a typeReferenceDirectives array. Maybe using that would be a better idea?
(these is also libReferenceDirectives)

That way, you can really re-create the tripleslash references manually.
Regarding the issue you opened for rollup, I think it is guaranteed to remove those comments, right? So we will not end up with a case where we end up with duplicated comments, right?

[aleclarson]

Nice, I didn't see the typeReferenceDirectives property before.

I think it is guaranteed to remove those comments, right? So we will not end up with a case where we end up with duplicated comments, right?

I don't think so. I see a preserved directive in the .d.ts bundle of @react-spring/web. 😕 Looks like we'll need a test case for that.

[aleclarson]

Though, that might be because I'm using the renderChunk hook to prepend the comment pragmas. There might be a better place to do that?

[Swatinem]

Looks like we'll need a test case for that.

yes, that was also my thought to test that comments that are attached to items are correctly preserved / removed. that pragma is kind of weird, according to astexplorer its attached to the export statement, but that does not really make sense IMO.

[Swatinem]

nice!

[Swatinem]

Thank you very much :-)
I will publish this tomorrow, and possibly play a bit more with comment attachment when I find some time.