Reach handling #27
Merged
Reach handling #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reach was previously excluded because the Temperature module had to identify if a device class defines reach and would also detect the reach defined in EmptyDevice. Now, the Temperature module has a more sophisticated check that is able to distinguish between reach defined in EmptyDevice or in the device class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reach() is a sequencer function and thus should be defined in the EmptyDevice class. Application logic that needs to check if reach was overridden by an instrument driver, should use appropriate code (i.e. check the
__dict__of the cls)