Added Instagram Uri #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Instagram to project file and updated Readme Fix a typo
|
Looks good tested it |
| return nil | ||
|
|
||
| case .Media(let id): | ||
| return "p/-\(id)/" |
There was a problem hiding this comment.
I guess my assumption was wrong the url for the images seems to be random.Like this one https://www.instagram.com/p/_ANch4BccQ/
Or
https://www.instagram.com/p/9GSY9uBali/
There was a problem hiding this comment.
@h0lyalg0rithm ok, we probably need some test IDs from the API. As far as I can tell, there are different kinds of IDs, and I haven't used instagram API before to know the difference. Do you think you can look into that?
|
Looking awesome, just need to take care of the minor media URL issue, then it'll be good to go |
|
rebased in #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Instagram to project file and updated Readme
Fix a typo in the README