Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrisharper22's submission for Challenge 2 #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chrisharper22
Copy link

This is my submission for the second challenge.

There are some things to take note of here:

  • There is further practice of using view-owned property subviews vs. standalone reusable views.
  • Asynchronous tasks are used to drive state changes. (Was this necessary? No, I felt like it).
  • A Task extension is used to allow seconds instead of nanoseconds (because I hate it).
  • A custom ProgressViewStyle is included, which I haven't seen much of anywhere.
    • This is better than creating a whole different view for something that's already included. Additionally, it showcases that custom ProgresView styles are possible, which I'm assuming isn't common knowledge.
    • It explores different init methods for further reusability (which I guess would be beyond the scope of these challenges?)
  • The view model (AirDropAvatarViewModel) is (mostly) documented with code comments.

Here's what it looks like:

Challege.2.mov

@DaemonLoki
Copy link
Contributor

Not only is the animation on point, but I also love the detailed explanation and the architectural thoughts that went into it.

That's definitely bonus points that you receive there. :)

Will love to talk about that tonight in the live stream! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants