Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dependencies, remove Carthage, migrate to Xcode 14 / Swift 5 and add SPM support #29

Merged
merged 20 commits into from
Nov 1, 2022
Merged

Remove Dependencies, remove Carthage, migrate to Xcode 14 / Swift 5 and add SPM support #29

merged 20 commits into from
Nov 1, 2022

Conversation

kimar
Copy link
Collaborator

@kimar kimar commented Nov 1, 2022 •
edited
Loading

  • As id fields on the Mastodon API are generally string fields, I've migrated those as well.
  • I've introduced MastodonClientAuthenticated to omit the auth token in every single function call.
  • Test coverage using mocked network requests has been added for all MastodonClient/ MastodonClientAuthenticated public methods.

@kimar kimar requested a review from thbonk November 1, 2022 22:50
@kimar kimar marked this pull request as ready for review November 1, 2022 22:51
@kimar kimar self-assigned this Nov 1, 2022
thbonk
thbonk approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@thbonk thbonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimar kimar merged commit 2ec8536 into main Nov 1, 2022
@kimar kimar deleted the phoenix branch November 1, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbonk thbonk thbonk approved these changes

Assignees

@kimar kimar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimar @thbonk