Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a "url" property to JSONValue #15

Merged
merged 1 commit into from Jul 8, 2014
Merged

add a "url" property to JSONValue #15

merged 1 commit into from Jul 8, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2014

I added a convenient property "url" as NSURL to the JSONValue.

@lingoer
Copy link
Member

lingoer commented Jul 6, 2014

The idea is good.
But maybe the use case is too limited?

@lingoer
Copy link
Member

lingoer commented Jul 6, 2014

Maybe we can make it an extension?

@jpmcglone
Copy link

I agree it would make a nice extension. People may have other types of their own to add, like coordinates, point, size, etc.

I'm thinking about how I can use this library to create instances of my model classes from JSON.. still learning swift

lingoer added a commit that referenced this pull request Jul 8, 2014
add a "url" property to JSONValue
@lingoer lingoer merged commit f04211e into SwiftyJSON:master Jul 8, 2014
nghuiqin pushed a commit to nghuiqin/SwiftyJSON that referenced this pull request Sep 20, 2016
Updated travis file to point to new code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants