fix: fixed serialization of creators (#550)

Author: jsam

renku/models/datasets.py

@@ -156,6 +156,17 @@ class Language:
     name = jsonld.ib(default=None, kw_only=True, context='schema:name')
 
 
+def _convert_dataset_files_creators(value):
+    """Convert dataset files creators."""
+    coll = value
+
+    if isinstance(coll, dict):
+        return [Creator.from_jsonld(coll)]
+
+    if isinstance(coll, list):
+        return [Creator.from_jsonld(c) for c in coll]
+
+
 @jsonld.s(
     type='schema:DigitalDocument',
     slots=True,
@@ -165,7 +176,10 @@ class DatasetFile(CreatorsMixin):
     """Represent a file in a dataset."""
 
     creator = jsonld.container.list(
-        Creator, kw_only=True, context='schema:creator'
+        Creator,
+        converter=_convert_dataset_files_creators,
+        kw_only=True,
+        context='schema:creator'
     )
 
     added = jsonld.ib(context='schema:dateCreated', kw_only=True)
@@ -229,7 +243,7 @@ def _convert_dataset_files(value):
 def _convert_dataset_creator(value):
     """Convert dataset creators."""
     if isinstance(value, dict):  # compatibility with previous versions
-        return Creator.from_jsonld(value)
+        return [Creator.from_jsonld(value)]
 
     if isinstance(value, list):
         return [Creator.from_jsonld(v) for v in value]

tests/cli/test_datasets.py

@@ -728,6 +728,7 @@ def test_dataset_import_real_doi(runner, project):
         ('10.5281/zenodo.3239984', 'n'),
         ('10.5281/zenodo.3239982', 'n'),
         ('10.5281/zenodo.3239980', 'n'),
+        ('10.5281/zenodo.3188334', 'y'),
     ]
 )
 @pytest.mark.integration
@@ -741,6 +742,9 @@ def test_dataset_import_real_param(doi, runner, project):
     if 'y' == doi[1]:
         assert 'OK' in result.output
 
+    result = runner.invoke(cli.cli, ['dataset'])
+    assert 0 == result.exit_code
+
 
 @pytest.mark.integration
 def test_dataset_import_real_doi_warnings(runner, project):