fix(cli): fail when removing non existing dataset

Author: jirikuncar

renku/cli/dataset.py

@@ -323,7 +323,23 @@ def unlink(client, name, include, exclude, yes):
 def remove(client, names):
     """Delete a dataset."""
     from renku.models.refs import LinkReference
-    datasets = {client.dataset_path(name) for name in names}
+    datasets = {name: client.dataset_path(name) for name in names}
+
+    if not datasets:
+        raise click.BadParameter(
+            'use dataset name or identifier', param_hint='names'
+        )
+
+    unknown = [
+        name
+        for name, path in datasets.items() if not path or not path.exists()
+    ]
+    if unknown:
+        raise click.BadParameter(
+            'unknown datasets ' + ', '.join(unknown), param_hint='names'
+        )
+
+    datasets = set(datasets.values())
 
     with progressbar(
         datasets,

tests/cli/test_datasets.py

@@ -586,6 +586,13 @@ def test_dataset_unlink_file(tmpdir, runner, client):
 
 def test_dataset_rm(tmpdir, runner, project, client):
     """Test removal of a dataset."""
+    # try to delete non existing dataset
+    result = runner.invoke(cli.cli, ['dataset', 'rm'])
+    assert 2 == result.exit_code
+
+    result = runner.invoke(cli.cli, ['dataset', 'rm', 'does-not-exist'])
+    assert 2 == result.exit_code
+
     # create a dataset
     result = runner.invoke(cli.cli, ['dataset', 'create', 'my-dataset'])
     assert 0 == result.exit_code