Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: resolve lineage in submodules #122

Conversation

jirikuncar
Copy link
Contributor

(closes #120)

@jirikuncar jirikuncar requested a review from a team as a code owner February 27, 2018 14:40
@rokroskar
Copy link
Member

renga log just follows the symlink -- should it also state that the file comes from a submodule explicitly?

$ renga log woop.wc
*  3593c280 woop.wc
*  3593c280 .renga/workflow/5b2ea16447154a93bbbbf4ac16bb93c4_wc.cwl
@  73fd3ec1 .renga/vendors/local/Users/rok/temp/foo/data/dataset/woop

@rokroskar
Copy link
Member

not sure what I should expect to see here or whether this is intended. I've got two repositories, one has imported a file from the other. I've changed the file in the submodule, I've done

git submodule --rebase --remote
git commit -a -m 'update submodule'

and then expected to see the submodule info in renga status but I get:

renga status
On branch master
Files generated from outdated inputs:
  (use "renga log <file>..." to see the full lineage)

	woop.wc:

@jirikuncar
Copy link
Contributor Author

@rokroskar can you provide me full history of the commands you run to reproduce the problem? Normally it should display: <name_of_submodule>@<commit_sha1>. Please note that the history for datasets works only if the submodule is a Renga repository.

@rokroskar rokroskar merged commit 3942e43 into SwissDataScienceCenter:development Mar 1, 2018
@jirikuncar jirikuncar deleted the 120-lineage-in-submodules branch March 1, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants