Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XKCD commands + #115 fix #113

Merged
merged 10 commits into from
Jun 17, 2018
Merged

XKCD commands + #115 fix #113

merged 10 commits into from
Jun 17, 2018

Conversation

pedrofracassi
Copy link
Member

@pedrofracassi pedrofracassi commented Jun 17, 2018 •
edited
Loading

New stuff

  • s!xkcd <#|latest> - Shows a random XKCD. You can also pass "latest" to get the latest one, or even a number to get a specific one.
  • s!xkcd37 <sentence> - Hyphen.

Closes #111
Closes #115

@pedrofracassi pedrofracassi added the scope: commands New command(s) suggestion/addition label Jun 17, 2018
@pedrofracassi pedrofracassi changed the title XKCD commands XKCD commands + #113 fix Jun 17, 2018
@pedrofracassi pedrofracassi changed the title XKCD commands + #113 fix XKCD commands + #115 fix Jun 17, 2018
@pedrofracassi pedrofracassi mentioned this pull request Jun 17, 2018
Closed
@pedrofracassi pedrofracassi requested a review from a team June 17, 2018 12:36
Doges
Doges approved these changes Jun 17, 2018
View reviewed changes
Copy link
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Doges Doges requested review from Doges and a team June 17, 2018 13:20
Doges
Doges approved these changes Jun 17, 2018
View reviewed changes
Copy link
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, lgtm again

jaxxibae
jaxxibae approved these changes Jun 17, 2018
View reviewed changes
Copy link
Member

@jaxxibae jaxxibae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jaxxibae jaxxibae merged commit 489534f into master Jun 17, 2018
@jaxxibae jaxxibae deleted the xkcd-command branch June 17, 2018 14:39
@jaxxibae jaxxibae mentioned this pull request Jul 4, 2023
Closed
@LogGame-HU-DEaN LogGame-HU-DEaN mentioned this pull request Oct 27, 2023
Open
@jaxxibae jaxxibae mentioned this pull request Oct 27, 2023
Closed
@LogGame-HU-DEaN LogGame-HU-DEaN mentioned this pull request Nov 27, 2023
Open
@jaxxibae jaxxibae mentioned this pull request Nov 28, 2023
Closed
@LogGame-HU-DEaN LogGame-HU-DEaN mentioned this pull request Dec 19, 2023
Open
@jaxxibae jaxxibae mentioned this pull request Dec 20, 2023
Closed
@jaxxibae jaxxibae mentioned this pull request Dec 27, 2023
Closed
@LogGame-HU-DEaN LogGame-HU-DEaN mentioned this pull request Dec 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxxibae jaxxibae jaxxibae approved these changes

@Doges Doges Doges approved these changes

@davipatury davipatury Awaiting requested review from davipatury

@nirewen nirewen Awaiting requested review from nirewen

Assignees
No one assigned
Labels
scope: commands New command(s) suggestion/addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedrofracassi @Doges @jaxxibae