Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor restyle of order credit memo list ui #198

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Minor restyle of order credit memo list ui #198

merged 1 commit into from
Mar 11, 2020

Conversation

diimpp
Copy link
Member

@diimpp diimpp commented Mar 5, 2020 •
edited
Loading

  • Updates color schema for credit memo Show/Download buttons to neutral gray/secondary action blue. Buttons are grouped.
  • Replaces custom channel widget (Visually incorrect) with @SyliusAdmin/Common/_channel.html.twig'
  • Adds issuedAt value to header of credit memo details page (No issued at value without it at all)
  • Cleans trailing whitespaces in README

Before
image

After
image

P.S. I've renamed Show button to Details, which looks better to me, but this change is optional and I can revert it.

@diimpp diimpp requested a review from a team as a code owner March 5, 2020 16:03
@diimpp diimpp force-pushed the order_credit_memo_list_redesign branch from 8118ac2 to 02c822b Compare March 5, 2020 16:13
@diimpp diimpp force-pushed the order_credit_memo_list_redesign branch from 02c822b to a931080 Compare March 11, 2020 11:51
CoderMaggie
CoderMaggie approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @diimpp, thank you! <3

@diimpp diimpp force-pushed the order_credit_memo_list_redesign branch from d4af85a to 9eff4e3 Compare March 11, 2020 16:17
@lchrusciel lchrusciel merged commit 99a06c3 into Sylius:master Mar 11, 2020
@lchrusciel
Copy link
Member

Thanks, Dmitri! 🎉

@lchrusciel lchrusciel added the UX/UI Issues and PRs aimed at improving User eXperience and User Interface. label Mar 11, 2020
@diimpp diimpp deleted the order_credit_memo_list_redesign branch March 12, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
UX/UI Issues and PRs aimed at improving User eXperience and User Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diimpp @lchrusciel @CoderMaggie