Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product grid broken on mobile #16379

Closed
t-n-y opened this issue Jun 12, 2024 · 1 comment
Closed

Product grid broken on mobile #16379

t-n-y opened this issue Jun 12, 2024 · 1 comment
Labels
Bug Confirmed bugs or bugfixes. Shop ShopBundle related issues and PRs.

Comments

@t-n-y
Copy link

t-n-y commented Jun 12, 2024

Sylius version affected: 1.12.16

Description
after the product grid fix #16190, the mobile view is broken
Capture d’écran 2024-06-12 à 11 23 33

Steps to reproduce
Go to a taxon page and resize page to mobile view
@Yanick-K Yanick-K mentioned this issue Jun 12, 2024
Merged
@diimpp diimpp added Shop ShopBundle related issues and PRs. Bug Confirmed bugs or bugfixes. labels Jun 12, 2024
GSadee added a commit that referenced this issue Jul 1, 2024
@GSadee
style #16380 Fix products grid for mobile (Yanick-K)
d821dd6 
This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.12 <!-- see the comment below -->
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | fixes [#16379](#16379)
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.12 or 1.13 branches
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->

On Mobile: 

Then 
![Capture d’écran 2024-06-12 à 17 30 07](https://github.com/Sylius/Sylius/assets/6756788/cd32d03d-ae39-400a-b7c4-fa19b2d6d3c3)


Now 
![Capture d’écran 2024-06-12 à 17 30 37](https://github.com/Sylius/Sylius/assets/6756788/6d1a3931-f6f6-4208-9854-22f76ee8a5e6)


Commits
-------

3536620 Fix products grid for mobile
@mpysiak
Copy link
Member

mpysiak commented Jul 15, 2024

Issue was fixed in #16380

@mpysiak mpysiak closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. Shop ShopBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@diimpp @t-n-y @mpysiak