Currencies API + first approach to API Behat tests #11128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Feb 18, 2020
Zales0123
commented
| Q | A |
|---|---|
| Branch? | api |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Zales0123
added
Feature
Zales0123
force-pushed
the
api-testing-behat
branch
from
36223e7
to
b1ab6b1
Compare
AdamKasp
reviewed
Feb 19, 2020
lchrusciel
reviewed
Feb 19, 2020
src/Sylius/Behat/Context/Api/Admin/ManagingCurrenciesContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCurrenciesContext.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
Feb 19, 2020
| $this->client->request('GET', '/new-api/'.$resource, [], [], ['HTTP_ACCEPT' => 'application/ld+json']); | ||
| } | ||
|
|
||
| public function buildCreateRequest(string $resource): void |
There was a problem hiding this comment.
In the next iteration, maybe client and request could be separate objects (to not make service stateful), and request could be some VO, or created fluent interfaces?
src/Sylius/Behat/Context/Api/Admin/ManagingCurrenciesContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCurrenciesContext.php
Outdated
Show resolved
Hide resolved
lchrusciel
approved these changes
Feb 19, 2020
| */ | ||
| public function iShouldBeNotifiedThatSomethingHappened(): void | ||
| { | ||
| Assert::true($this->client->isCreationSuccessful(), 'Currency could not be created'); |
There was a problem hiding this comment.
Suggested change
| Assert::true($this->client->isCreationSuccessful(), 'Currency could not be created'); | |
| Assert::true($this->client->isCreationSuccessful(), 'Resource could not be created'); |
|
Thank you, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.