-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixtures] Externalized fixtures #1135
Conversation
Good starting point for #1021. Next step would to clean and refactor our fixtures to able to use them in our Behat scenarios. |
@jjanvier I guess you mean other way =) Clean & refactor Behat contexts to use our fixtures =) |
@stloyd actually I was thinking about creating some sort of builders in the FixturesBundle. These builders could be used for Behat contexts. We'll have to refactor Behat contexts of course, but this bundle too, that's what I meant. What do you think ? Anyway, 👍 for this. |
@stloyd @pjedrzejewski interested by this ? you did not give your opinion ? a chance to be merged quickly ? |
This is interesting, it will lighten CoreBundle a bit and make things extendable. |
Yes it is interesting. @jjanvier agree with you for the builders! |
I think it is a good step towards unification of Behat & normal fixtures. This PR requires a rebase and I'll setup repository & subtree split stuff for this new bundle. @csarrazi 👍 |
This enables the use of SyliusCoreBundle without the default fixtures
@pjedrzejewski Done. |
[Fixtures] Externalized fixtures
Thank you Charles. I'll synchronize the repository and add the composer package. Nice work! |
You're welcome! :) |
This enables the use of SyliusCoreBundle without the default fixtures.
Without this, it is impossible to override the default fixtures with your own fixtures. Requires a new sub-tree-split.