Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixtures] Externalized fixtures #1135

Merged
merged 1 commit into from
Mar 4, 2014
Merged

[Fixtures] Externalized fixtures #1135

merged 1 commit into from
Mar 4, 2014

Conversation

csarrazi
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR none

This enables the use of SyliusCoreBundle without the default fixtures.

Without this, it is impossible to override the default fixtures with your own fixtures. Requires a new sub-tree-split.

@jjanvier
Copy link
Contributor

Good starting point for #1021. Next step would to clean and refactor our fixtures to able to use them in our Behat scenarios.

@stloyd
Copy link
Contributor

stloyd commented Feb 28, 2014

@jjanvier I guess you mean other way =) Clean & refactor Behat contexts to use our fixtures =)

@jjanvier
Copy link
Contributor

@stloyd actually I was thinking about creating some sort of builders in the FixturesBundle. These builders could be used for Behat contexts. We'll have to refactor Behat contexts of course, but this bundle too, that's what I meant. What do you think ?

Anyway, 👍 for this.

@jjanvier
Copy link
Contributor

jjanvier commented Mar 3, 2014

@stloyd @pjedrzejewski interested by this ? you did not give your opinion ? a chance to be merged quickly ?

@winzou
Copy link
Contributor

winzou commented Mar 4, 2014

This is interesting, it will lighten CoreBundle a bit and make things extendable.
Requires rebase @csarrazi

@arnolanglade
Copy link
Contributor

Yes it is interesting. @jjanvier agree with you for the builders!

@pjedrzejewski
Copy link
Member

I think it is a good step towards unification of Behat & normal fixtures. This PR requires a rebase and I'll setup repository & subtree split stuff for this new bundle. @csarrazi 👍

This enables the use of SyliusCoreBundle without the default fixtures
@csarrazi
Copy link
Contributor Author

csarrazi commented Mar 4, 2014

@pjedrzejewski Done.

pjedrzejewski pushed a commit that referenced this pull request Mar 4, 2014
@pjedrzejewski pjedrzejewski merged commit f7573fd into Sylius:master Mar 4, 2014
@pjedrzejewski
Copy link
Member

Thank you Charles. I'll synchronize the repository and add the composer package. Nice work!

@csarrazi
Copy link
Contributor Author

csarrazi commented Mar 4, 2014

You're welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants