[CatalogPromotion][API] Extend the possibility of editing catalog promotion #13013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Aug 27, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
SirDomin
approved these changes
Aug 27, 2021
arti0090
approved these changes
Aug 27, 2021
Comment on lines
+272
to
+274
| $response = $this->client->show($catalogPromotion->getCode()); | ||
|
|
||
| Assert::true($this->responseChecker->hasTranslation($response, $localeCode, $field, $value)); |
There was a problem hiding this comment.
Suggested change
| $response = $this->client->show($catalogPromotion->getCode()); | |
| Assert::true($this->responseChecker->hasTranslation($response, $localeCode, $field, $value)); | |
| Assert::true($this->responseChecker->hasTranslation( | |
| $this->client->show($catalogPromotion->getCode()), | |
| $localeCode, | |
| $field, | |
| $value) | |
| ); |
wdyt? :D
There was a problem hiding this comment.
Or even in one line all of the params.
There was a problem hiding this comment.
I would be for leaving as it is now, for me, it looks clearer
Zales0123
approved these changes
Aug 27, 2021
| And I specify its label as "Christmas -50%" in "English (United States)" | ||
| And I describe it as "This promotion gives a 50% discount on all products" in "English (United States)" | ||
| And I save my changes | ||
| Then this catalog promotion label in "English (United States)" locale should be "Christmas -50%" |
There was a problem hiding this comment.
It's, of course, correct, but I feel we can go further with the naturalness of Behat steps
Then this catalog promotion should be labelled as "Christmas -50%" in "English (United States)
something like this? But still, it's good to go :D
| Given the catalog promotion "Christmas sale" is available in "United States" | ||
| When I want to modify a catalog promotion "Christmas sale" | ||
| And I make it available in channel "Europe" | ||
| And I make it unavailable in channel "United States" |
There was a problem hiding this comment.
Btw, should we already take it into account in catalog promotion application? To not apply it on variants that are not available in some channel? 🤔
|
Thanks, Grzegorz! 🎉 |
Zales0123
added a commit
that referenced
this pull request
Aug 27, 2021
… promotions scenarios (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | resolves comment #13013 (comment) | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 845df97 [CatalogPromotion][Behat] Remove duplicated feature file 5abf3de [CatalogPromotion][Behat] Minor improvements for catalog promotions scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.