Typo #1357
Merged
Typo #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@umpirsky needs rebase :p |
|
@jjanvier Rebased. |
|
|
||
| foreach ($container->findTaggedServiceIds('sylius.promotion_action') as $id => $attributes) { | ||
| $checkers[$attributes[0]['type']] = $attributes[0]['label']; | ||
| $actions[$attributes[0]['type']] = $attributes[0]['label']; |
There was a problem hiding this comment.
Also to prevent notices, please add simple validation:
if (!isset($attributes[0]['type'])) {
throw new \InvalidArgumentException('Tagged promotion action needs to have `type` attribute.');
}
if (!isset($attributes[0]['label'])) {
throw new \InvalidArgumentException('Tagged promotion action needs to have `label` attribute.');
}There was a problem hiding this comment.
I think there is no need. Since it can happen only because of bad config, which is usually during development. But I added them.
pjedrzejewski
pushed a commit
that referenced
this pull request
Apr 13, 2014
|
Thanks Sasha! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.