Split application Kernel and rename default one

[stloyd]

First step to conquer the world =)

[pjedrzejewski]

But why? I understand that not only Symfony uses the bundles and kernel system, but core kernel depends on bundles which require symfony-framework bundle. So if you use Sylius core with Symfony2, the recommended way is to use CoreBundle.

[stloyd]

@pjedrzejewski Maaan, sorry ;) Created PR from wrong branch... this was one of approaches but I dropped it.

Now it contains proper changes.

[stloyd]

@pjedrzejewski Did you looked at this one? =)

[stloyd]

@Sylius Any reason this is not merged yet?

[winzou]

actually, why would it be abstract?

[stloyd]

I guess it was done because it's in bundle folder, but the real reason is known to @pjedrzejewski only =)

[winzou]

Seems good to me, but need rebase.

[pjedrzejewski]

I'm not against, but just wondering what is the benefit of having separate Cli kernel? It will have separate and different cache/configuration than web kernel... Also, Sylius/Sylius is not the recommended starter for new projects, so this Kernel with "Put your bundles here" note is perfect, but for Sylius-Standard. What do you think?

[stloyd]

As said in description, it's first step to done this properly, I don't want to create one big step that will broke everything once and for all, but do it in small parts, that don't require so many code adjustments.

About split of kernels, the advantage is that you use only bundles you need, you never use migrations + fixtures in other place than in CLI, of course there could be also some cons, as with everything, but this way it's much cleaner, and it's one of steps on "longer road" to make Sylius better =)

[webda2l]

Add to CliKernel, some people also split the AdminKernel and AppKernel for security reason. Each kernel have only its required bundles and the admin part and front part can be hosted on different server with only required bundles codes.

[jjanvier]

The only drawback is that it makes Sylius a "non-standard" Symfony project.

But I like it. Not sure this is a "must have", but I like the idea of registering only what you need when you need it. The idea of @webda2l is really interesting too !

So 👍

[pjedrzejewski]

Requires rebase now. :)

[stloyd]

@pjedrzejewski Rebased, tests passed =)

[pjedrzejewski]

Thank you Joseph! This also solves my problem with the demo, where I load the fixtures in production environment.

[winzou]

@stloyd please fix:

InvalidArgumentException: There is no extension able to load the configuration for "doctrine_migrations"

doctrine_migrations is configured but the bundle not loaded while not in CLI => error.

[pjedrzejewski]

Ah crap... I missed this. Does it mean a separate config for CLI? I'm not sure this is worth it... especially it makes us less Symfony standard compatible as @jjanvier said, with little benefit.

[winzou]

I'm not in favor of a separate CLI config, it's complicating things for no real advantage.