Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move migrations configuration to prevent problems with configuration loaded when bundle was skipped #1431

Merged
merged 1 commit into from
Apr 25, 2014

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Apr 25, 2014

@stloyd
Copy link
Contributor Author

stloyd commented Apr 25, 2014

@winzou This is "workaround", but should work well till I find more proper thing to work well with configurations & bundles loading (I have something in mind for a long time, but this requires changes done in small steps, like the one in #1387).

@pjedrzejewski
Copy link
Member

@winzou What do you think?

@winzou
Copy link
Contributor

winzou commented Apr 25, 2014

The solution is OK, but it complicates thing and as @jjanvier said somewhere, we are getting away from the standard symfony project. So we need to wonder if the pro are heavier than loosing some newcomers because of that.

pjedrzejewski pushed a commit that referenced this pull request Apr 25, 2014
Move migrations configuration to prevent problems with configuration loaded when bundle was skipped
@pjedrzejewski pjedrzejewski merged commit 1d170fe into Sylius:master Apr 25, 2014
@stloyd stloyd deleted the bugfix/migrations_config branch April 25, 2014 14:07
@pjedrzejewski
Copy link
Member

I merged it for now, so that issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants