CS fixer #1432
Merged
CS fixer #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ class ConfirmOrderListener | |||
| /** | |||
| * Set an Order as completed | |||
| * | |||
| * @param GenericEvent $event | |||
| * @param GenericEvent $event | |||
There was a problem hiding this comment.
IIRC this is bug of CS fixer, correct way to fix this is new line, so phpdoc should look like:
/**
* Set an Order as completed
*
* @param GenericEvent $event
*
* @throws UnexpectedTypeException
*/
|
@pjedrzejewski Good to go? |
|
👍 looks good =) |
pjedrzejewski
pushed a commit
that referenced
this pull request
Apr 25, 2014
|
Thanks Sasha! |
|
CS nazzi is happy! 😄 |
tomzx
pushed a commit
to tomzx/Sylius
that referenced
this pull request
May 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.