[ResourBundle] The criteria don't care about empties values

[arnolanglade]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	-
License	MIT
Doc PR	-

[stloyd]

This is not proper fix IMO. There are for sure cases when you want to look for false, '' (empty string, rare but still), 0 etc.

[arnolanglade]

Agree for boolean or 0 but not for empty string. For a filter form you can not leave fields empties and it is annoying! I will update it soon. Thanks for feedback.

[arnolanglade]

Perhaps, I should only use $value != ""

[stloyd]

@Arn0d IMO this should be same as i.e. in Symfony\BlankValidator:

'' !== $value && null !== $value

[arnolanglade]

@stloyd yes I will only use '' !== $value because we already check if the value is null above.

[arnolanglade]

@Sylius/core-team Are you agree ?

[umpirsky]

} elseif (is_array($value)) {

[arnolanglade]

@umpirsky
It was :

elseif (!is_array($value)) {
      $queryBuilder
            ->andWhere($queryBuilder->expr()->eq($this->getPropertyName($property), ':' . $property))
            ->setParameter($property, $value);
 } else {
      $queryBuilder->andWhere($queryBuilder->expr()->in($this->getPropertyName($property), $value));
}

And now, it is :

} elseif(is_array($value)) {
      $queryBuilder->andWhere($queryBuilder->expr()->in($this->getPropertyName($property), $value));
} elseif ('' !== $value) {
      $queryBuilder
            ->andWhere($queryBuilder->expr()->eq($this->getPropertyName($property), ':' . $property))
            ->setParameter($property, $value);
 }

[stloyd]

@Arn0d Saša is not talking about your change was wrong or not, he just points you to fix CS (note missing space between elseif & ().

[arnolanglade]

OK! Done!

[umpirsky]

:)

[arnolanglade]

ping @pjedrzejewski

[arnolanglade]

@pjedrzejewski Are you agree with this? I need it for a project ! Can we merge it ?

[pjedrzejewski]

Thank you Arnaud!

[arnolanglade]

You're welcome!