Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Be2bill multiple payment #1508

Merged
merged 1 commit into from
May 15, 2014
Merged

Conversation

winzou
Copy link
Contributor

@winzou winzou commented May 15, 2014

Introduced in #1203
Be2bill needs a proper id so that we can retrieve it in the unsafe notification.

@pjedrzejewski
Copy link
Member

@kayue I think this is good, because we can always retrieve the order from the payment. Also, I think we will support payments without orders in future. What is your opinion on this?

@winzou
Copy link
Contributor Author

winzou commented May 15, 2014

This order_number-paymennt_id was a display tuning for paypal, but it's actually not valid for be2bill, which needs a proper id and not this concatenation of order and payment.

@kayue
Copy link
Contributor

kayue commented May 15, 2014

OK 👍

@elliot
Copy link
Contributor

elliot commented May 15, 2014

Payments without Orders will come in handy for a Subscription component

pjedrzejewski pushed a commit that referenced this pull request May 15, 2014
Fix Be2bill multiple payment
@pjedrzejewski pjedrzejewski merged commit 65f7045 into Sylius:master May 15, 2014
@pjedrzejewski
Copy link
Member

Behat3 seems faster... Thanks Alexandre! 👍

@winzou winzou deleted the fix/be2bill branch May 16, 2014 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants