Fixed issue #1549

[umpirsky]

No description provided.

[arnolanglade]

Now the build failed for PHP 5.4, I just restarted in case of.. but it should be green :)

[umpirsky]

Thanks @Arn0d !

[arnolanglade]

\o/ Now PHP5.4 is green but not PHP5.3 and PHP5.5 !

[umpirsky]

OK, then we can merge :)

[arnolanglade]

Thanks Saša!

[winzou]

Have you tested it? Not sure if the preflush is right here, I will have a look. Your issue was strange, did you find why exactly your number didn't get persisted?

[arnolanglade]

Oups, the build was green. Perhaps, I click on merge quickly, sorry. Can you give us feedback ?

[umpirsky]

I just know that it got flushed after I made this change.

[winzou]

@umpirsky your fix is not working. It seems that the unit of work returns nothing for scheduledEntityUpdates and scheduledEntityInsertions in the preFlush event => the listener doesn't go in the foreach and so no generator is called. I'm testing with the classic checkout workflow. Please revert or fix asap.

[pjedrzejewski]

Right, it does not work and all number are empty now... We should probably have a scenario to cover the numbers generation to have this issue solved once and for all...

Btw. latest master demo is available at http://master.sylius.sylius.stage1.io/. (I will set demo.sylius.org to use stage1 soon)

[umpirsky]

$this->listener->enableEntity($order); is never called. Isn't this maybe related to removing OrderNumberListener form config and finite does not doing its job @winzou ?

[winzou]

@umpirsky I'm on master and the enableEntity is well called.
In the preFlush method I do:

var_dump($this->entitiesEnabled);
var_dump($uow->getScheduledEntityUpdates());
var_dump($uow->getScheduledEntityInsertions());

And I get:

array (size=1)
  '000000000b52ca3800000000659e9ef9' => boolean true
array (size=0)
  empty
array (size=0)
  empty

So this is really this preFlush that is not working.
If I switch to dd694f243b which is just before the move from onFlush to preFlush then everything is working well.

[umpirsky]

I am on master branch too, and I get no dumps, and $this->listener->enableEntity($order); is never called for me.

I am testing with:

$ ./app/console do:fi:lo --no-interaction

How do you test @winzou?

[winzou]

Same as you. Really strange that the entity is not enabled at your place...
But anyway, it is at mine, and then the preFlush is not working. I've reverted your change + added scenario: #1560