[API] Automatically add a default translation to translatables #15501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Nov 6, 2023
NoResponseMate
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | kinda |
| New feature? | no? |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
GSadee
previously approved these changes
Nov 7, 2023
src/Sylius/Bundle/ApiBundle/spec/Serializer/TranslatableDenormalizerSpec.php
Outdated
Show resolved
Hide resolved
NoResponseMate
force-pushed
the
SYL-3159/api-initialize-default-translation
branch
from
e5fb893
to
0708088
Compare
jakubtobiasz
previously approved these changes
Nov 7, 2023
NoResponseMate
force-pushed
the
SYL-3159/api-initialize-default-translation
branch
from
a3420a1
to
9012465
Compare
TheMilek
approved these changes
Nov 8, 2023
jakubtobiasz
approved these changes
Nov 8, 2023
|
Thank you, @NoResponseMate! |
NoResponseMate
deleted the
SYL-3159/api-initialize-default-translation
branch
jakubtobiasz
added a commit
that referenced
this pull request
Nov 10, 2023
…le (GSadee) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13| | Bug fix? | yes? | | New feature? | no | | BC breaks? | no | | Deprecations? | no| | Related tickets | related to #15501 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [API] Improve contract test of creating a product with invalid translation locale [API] Disallow removing the translation in default locale [API] Adjust contract tests after changes with translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.