[payum] payum does not store details after user is returned from payment #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $details['PAYMENTREQUEST_0_NOTIFYURL'] = $this->tokenFactory->createNotifyToken( | ||
| $request->getToken()->getPaymentName(), | ||
| $payment | ||
| )->getTargetUrl(); | ||
| $details['PAYMENTREQUEST_0_INVNUM'] = $order->getNumber().'-'.$payment->getId(); | ||
| $details['PAYMENTREQUEST_0_CURRENCYCODE'] = $order->getCurrency(); | ||
| $details['PAYMENTREQUEST_0_CURRENCYCODE'] = 'USD'; |
There was a problem hiding this comment.
uhm?
Actually it should be $payment->getCurrenty() as we rely on payment and not order anymore.
There was a problem hiding this comment.
argh, my bad, I put it for debug purpose here to avoid multi-currency issue.
winzou
added a commit
that referenced
this pull request
Jun 12, 2014
…ls-after-returning-back [payum] payum does not store details after user is returned from payment
|
Let's give it a try, thanks |
|
All good! |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1602 and probably #1605
/cc @winzou