Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjustments on .gitignore #1876

Merged

Conversation

cordoval
Copy link
Contributor

@cordoval cordoval commented Sep 5, 2014

Q A
Bug Fix? n
New Feature? n
BC Breaks? n
Deprecations? n
Tests Pass? n
Fixed Tickets
License MIT
Doc PR

Sent using Gush

@sstok
Copy link
Contributor

sstok commented Sep 6, 2014

Its actually a convention to end directories with / to prevent mismatching with files.
In this case it will not be a big problem, but keep it in mind ;)

Besides that: 👍

@cordoval
Copy link
Contributor Author

cordoval commented Sep 6, 2014

yeah i also do / in front to match only the root project directories to avoid mismatching, but really no need to go that far and keep it simple. 👻

pjedrzejewski pushed a commit that referenced this pull request Sep 12, 2014
@pjedrzejewski pjedrzejewski merged commit 2903e50 into Sylius:master Sep 12, 2014
@pjedrzejewski
Copy link
Member

Thank you Luis! 👍

@cordoval cordoval deleted the could-we-ignore-cache-entirely branch September 12, 2014 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants