Create Archetype Component and Bundle to replace Product Prototype and allow for inheritance

[adamelso]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets	#2001
License	MIT
Doc PR	pending

The new Archetype component and bundle is designed to replace the existing Product Prototypes, introducing inheritance between archetypes, and to be abstract, so any model other than a product can be the subject of archetyping.

I'll probably need some assistance with resolving the interfaces to the correct Doctrine mapping, or whether my implement is correct or not.

• Create Archetype component
• Pass specification tests
• Create Archetype bundle
• Replace Product Prototype with Archetype
  • Update services
  • Update Doctrine mapping
  • Update validation
  • Update translation fields
  • Map parent and child via LoadMetadataSubscriber instead of XML to make mapping valid
• Pass feature tests

[pjedrzejewski]

@adamelso I looked around briefly, awesome work! But why we need another set of classes in the archetype component? Can't it just use the ones that we define in Variation and Attribute component?

[adamelso]

@pjedrzejewski Cool! Thank you. Yeah, I wasn't sure if I needed to do this in the same way that the classes were being extended for the Product component but we don't need them and I've now removed those intermediate models.

[adamelso]

Unfortunately, I am unable to use the Tree Doctrine extension like Taxonomy does, because the parent mapping has to be done dynamically for each subject (eg. Product) and trying to hook into the DoctrineExtensions metadata config is really hard: https://github.com/Atlantic18/DoctrineExtensions/blob/master/lib/Gedmo/Tree/Mapping/Driver/Xml.php#L170

[adamelso]

Do we need to casade on delete for archetype options?

[pjedrzejewski]

@adamelso I've sent you a PR with few tweaks and simplifications. Really nice work! If you accept my PR, we can rebase this one and merge it into the core! :) adamelso#4

[pjedrzejewski]

@adamelso I also added automatic product updates when the Archetype changes, new attributes are added automatically. Let me know if you can merge it and rebase it soon, otherwise I will open a separate PR. :) /cc @peteward

[adamelso]

@pjedrzejewski Awesome! I see that you've create a new PR #2298 . Do you still need me to do anything on my part? In the meantime I'm going to test this with my classifieds ads project to see how it works.

[peteward]

We'll need to add Translations for the Archetype entity, but this should be easy enough (and shouldn't hold up this PR).

[adamelso]

Should ArchetypeSubjectInterface perhaps not extend the AttributeSubjectInterface and VariableInterface ? I'm thinking a scenario where an archetype may only use attributes, but not options, yet the ArchetypeSubjectInterface requires the implementation of methods that manipulate options.

Instead, the building of attributes or options can be taking care in an implementation of ArchetypeBuilderInterface::build().

[adamelso]

@peteward I can start working on making this translatable during this week.

[pjedrzejewski]

Thank you Adam! Awesome work. 👍

[peteward]

@adamelso, I've asked @gonzalovilaseca to implement translations for this new component.
He did all of the original translation work so can do this very quickly.

You haven't started it have you?

[adamelso]

@peteward Perfect, I'll leave it for him to implement as he'll be able to deliver it faster than I would; I don't with Sylius full time, only evenings and weekends. :)

On 21 Jan 2015, at 09:18, Peter Ward notifications@github.com wrote:

@adamelso, I've asked @gvilaseca to implement translations for this new component.
He did all of the original translation work so can do this very quickly.

You haven't started it have you?

—
Reply to this email directly or view it on GitHub.

[gonzalovilaseca]

PR sent! #2402