Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] the component has been reworked #2260

Merged
merged 1 commit into from
Jan 5, 2015

Conversation

arnolanglade
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR -

@arnolanglade arnolanglade force-pushed the translations_component branch 2 times, most recently from 045deae to e31ae50 Compare December 18, 2014 12:58
@arnolanglade
Copy link
Contributor Author

@pjedrzejewski Still a pending spec but I don't know how write it!

@arnolanglade
Copy link
Contributor Author

    public function removeTranslation(TranslationInterface $translation)
    {
        if ($this->translations->removeElement($translation)) {
            $translation->setTranslatable(null); // <-- This should be removed, no ?
        }

        return $this;
    }

@pjedrzejewski
Copy link
Member

Why removed?

@arnolanglade
Copy link
Contributor Author

@pjedrzejewski if the translation is removed from the collection. Anyway, have you got a ideas for the spec?

@arnolanglade
Copy link
Contributor Author

@pjedrzejewski finished

@arnolanglade arnolanglade changed the title [WIP][Translation] the component has been reworked [Translation] the component has been reworked Jan 4, 2015
pjedrzejewski pushed a commit that referenced this pull request Jan 5, 2015
[Translation] the component has been reworked
@pjedrzejewski pjedrzejewski merged commit 3d33b19 into Sylius:master Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants