[ShippingBundle] Form registration, missing specs and CS #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arnolanglade
commented
Jun 10, 2015
arnolanglade
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | refactoring |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | no |
| License | MIT |
| Doc PR | - |
|
Is it still WIP? |
|
yes ! |
arnolanglade
changed the title
arnolanglade
force-pushed
the
shipping_form
branch
from
10725ec
to
949bfc9
Compare
|
@pjedrzejewski Finished, can you restart the build ? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jun 11, 2015
[ShippingBundle] Form registration, missing specs and CS
|
You are crazy man, awesome work! 👍 Thank you! |
|
✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.