Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceBundle] fix merging request and config sorting parameters #2832

Merged
merged 1 commit into from
Jun 11, 2015

Conversation

Strontium-90
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets
License MIT
Doc PR

If specify default sorting order in config:

sylius_backend_country_index:
    path: /
    methods: [GET]
    defaults:
        _controller: sylius.controller.country:indexAction
        _sylius:
            template: SyliusWebBundle:Backend/Country:index.html.twig
            sortable: true
            paginate: 50
            sorting:
                name: asc

and trying sort table manually GET /administration/countries/?sorting%5BisoName%5D=asc
Query will contain:

ORDER BY o.name ASC, o.isoName ASC

but should be

ORDER BY o.isoName ASC, o.name ASC

pjedrzejewski pushed a commit that referenced this pull request Jun 11, 2015
[ResourceBundle] fix merging request and config sorting parameters
@pjedrzejewski pjedrzejewski merged commit 5183237 into Sylius:master Jun 11, 2015
@pjedrzejewski
Copy link
Member

Makes sense, thank you again Aleksey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants