-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add customer show api path #3734
Conversation
@@ -20,7 +20,7 @@ Sylius\Component\User\Model\User: | |||
relations: | |||
- rel: user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that proper fix will be to change this rel
to customer, since we still do id: expr(object.getCustomer().getId())
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if you want the User link, change to:
- rel: self
href:
route: sylius_api_user_show
parameters:
id: expr(object.getId())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so should I leave the route as it was before? but then it has to be created in some routing.yml file as it doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so we have a bug 😄
Proper fix - add route for api customer show
Quick fix - remove this rel
Are you willing to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I found it bc it was breaking my app! I'll fix it during the day.
I've added the route in the |
@gonzalovilaseca it's better to create a |
@michalmarcinkowski updated! |
[API] Add customer show api path
Thank you Gonzalo! 👍 |
sylius_api_customer_show
route doesn't exist, should we create it or just usesylius_api_user_show
?