[Cart] remove deprecated isFresh() method from CartEvent #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older versions of Sylius the cart totals were recalculated (aka the cart was "refreshed") via setting the CartEvent to fresh and checking if it is fresh on the right places. If the event was fresh, the cart was recalculated. Now that is solved via triggering the SyliusCartEvents::CART_CHANGE event. The isFresh() method is removed (it was only set, resulting in a more convoluted code, but never checked for after the switch to event listeners).
|
@flajos I have restarted the build (looks like random fail). FYI the cart recalculation process will be totally reworked in the comming weeks :) |
|
Yep, thx, it seems OK now. I'm eager to see the rework :) |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 6, 2016
[Cart] remove deprecated isFresh() method from CartEvent
|
Thanks Lajos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of Sylius the cart totals were recalculated (aka the cart was "refreshed") via setting the CartEvent to fresh and checking if it is fresh on the right places. If the event was fresh, the cart was recalculated. Now that is solved via triggering the SyliusCartEvents::CART_CHANGE event. The isFresh() method is removed (it was only set, resulting in a more convoluted code, but never checked for after the switch to event listeners).