[Sylius/Behat] Use getUrl() instead of custom open() in ProductShowPage #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
the
Enhancement
pamil
force-pushed
the
product-show-page-get-url
branch
from
681713b
to
a8801b8
Compare
| { | ||
| return $this->router->generate($urlParameters['product'], [], true); |
There was a problem hiding this comment.
Maybe we should add check if product is set?
if (!isset($urlParameters['product']) {
\\ throw exception
}
d4b47c7
to
8e07dd0
Compare
|
Something went wrong with Travis, here's the passing build on my fork: https://travis-ci.org/pamil/Sylius/jobs/108260994 |
|
@pamil the passing build from your fork is not enough 😄 please repush, should be fine then. |
pamil
force-pushed
the
product-show-page-get-url
branch
from
8e07dd0
to
2aace5d
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Feb 10, 2016
[Sylius/Behat] Use getUrl() instead of custom open() in ProductShowPage
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.