[Behat][Promotion] Fixed discount promotion scenarios vol 2 #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
changed the title
Zales0123
force-pushed
the
fixed-discount-promotion-scenarios-vol-2
branch
from
449d0c4
to
29f68ad
Compare
michalmarcinkowski
added
the
Enhancement
|
We need a rebase here. |
Zales0123
force-pushed
the
fixed-discount-promotion-scenarios-vol-2
branch
from
29f68ad
to
1ac9d3d
Compare
|
Rebase done, but we should definitely wait for merging #4223 😄 |
Zales0123
force-pushed
the
fixed-discount-promotion-scenarios-vol-2
branch
3 times, most recently
from
66741ce
to
e7ba3e5
Compare
| */ | ||
| private function calculateAdjustmentAmount($promotionSubjectTotal, $targetPromotionAmount) | ||
| { | ||
| return ($promotionSubjectTotal < $targetPromotionAmount) ? -$promotionSubjectTotal : -$targetPromotionAmount; |
There was a problem hiding this comment.
-1 * min($promotionSubjectTotal, $targetPromotionAmount), wdyt? :D
Zales0123
force-pushed
the
fixed-discount-promotion-scenarios-vol-2
branch
from
89414a0
to
c6314af
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Feb 22, 2016
…arios-vol-2 [Behat][Promotion] Fixed discount promotion scenarios vol 2
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on previous #4199.
Two last scenarios in these feature implemented, also some changes in code to fit them.