[RFC][Behat] Extract reusable transformers #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,8 @@ | |||
| <parameter key="sylius.behat.context.setup.shipping.class">Sylius\Behat\Context\Setup\ShippingContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.zone.class">Sylius\Behat\Context\Setup\ZoneContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.tax.class">Sylius\Behat\Context\Setup\TaxContext</parameter> | |||
| <parameter key="sylius.behat.context.setup.lexical.class">Sylius\Behat\Context\Setup\LexicalContext</parameter> | |||
There was a problem hiding this comment.
IMHO new namespace sylius.behat.context.transform.* would be the most suitable for contexts that only transforms arguments
There was a problem hiding this comment.
Agreed 👍 I couldn't come up with some good name, bad transform is simple and accurate 😄
|
👍, we will have to use shared context directly only to set a resource after this PR gets merged! :) |
Zales0123
force-pushed
the
extract-reusable-transformers
branch
from
b3975b8
to
1f9f43c
Compare
pjedrzejewski
added
the
DX
Zales0123
force-pushed
the
extract-reusable-transformers
branch
from
7331229
to
d563782
Compare
| } | ||
|
|
||
| /** | ||
| * @Transform /^"([^"]+)%"$/ |
There was a problem hiding this comment.
Won't it be better to use here regex which will match only floats? ([0-9]*\.)?[0-9]+
There was a problem hiding this comment.
We can make it /^"((?:\d+\.)?\d+)%"$/ 🎉
There was a problem hiding this comment.
Anyway, same for price from string :)
Zales0123
force-pushed
the
extract-reusable-transformers
branch
2 times, most recently
from
a72a4fa
to
503386a
Compare
Also implement usage of LexicalContext in promotions steps
Zales0123
force-pushed
the
extract-reusable-transformers
branch
from
503386a
to
6b0f4aa
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Feb 24, 2016
[RFC][Behat] Extract reusable transformers
|
Thanks Mateusz! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid (current or future) duplications and make new behat scenarios even easier to write and it (they're already pretty natural 😄), here is propose of two additional contexts, containing reusable transformers. Concept is widely described in related issue, just to make it clear about new features:
SharedStorageContext:it-> transform to last resource fromSharedStoragethis|that|the {resource}-> transform to specific resource fromSharedStorageLexicalContext:€103.00(string) ->10300(int)20%(string) ->0.2(float)I'm sure we could find lots of more use cases that can be placed in one of this context. Moreover, I hope that by using them wisely, we could get rid of injecting
SharedContextinto most of contexts and minimize number of private functions.