[Admin] Country code immutability #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Mar 21, 2016
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | #4374 |
| License | MIT |
Arminek
force-pushed
the
country-code-immutability-while-editing
branch
from
d9390f3
to
08e0bc7
Compare
| */ | ||
| private function getMessageElement() | ||
| { | ||
| $messageElement = $this->createMessageElement(); |
There was a problem hiding this comment.
Can't we just use $this->session->find('css', '.message') instead?
There was a problem hiding this comment.
$this->session->getDriver()->find() won't work with css it operates on xpath only but i think we can change this, cuz i can get selectorsHandler from session.
There was a problem hiding this comment.
Ouch, I meant $this->session->getPage()->find('css', '.message') :) It works with the css selector.
Arminek
force-pushed
the
country-code-immutability-while-editing
branch
from
08e0bc7
to
039c3bc
Compare
Arminek
force-pushed
the
country-code-immutability-while-editing
branch
2 times, most recently
from
d5f30c6
to
ce648f4
Compare
Arminek
force-pushed
the
country-code-immutability-while-editing
branch
from
ce648f4
to
77be94f
Compare
| $codeField = $this->getElement('code'); | ||
| return $codeField->getAttribute('disabled') === 'disabled'; | ||
| } catch (ElementNotFoundException $exception) { | ||
| return false; |
There was a problem hiding this comment.
Do not catch exception, it will indicate that something is wrong instead of incorrectly saying that code field is not disabled.
|
Thank you Arek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.