-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[payum] update up to stable version. #462
Conversation
"payum/payum-bundle": "0.6.*@dev", | ||
"payum/paypal-express-checkout-nvp": "0.6.*@dev", | ||
"payum/omnipay-bridge": "0.6.*@dev" | ||
"payum/payum": "0.6.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we perhaps should switch this to ~0.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cordoval it does not make much difference for 0.x.x versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makasim It quite does, because this allow only the 0.6
and maintance release for this while ~0.6
will also get the 0.7
and never till 1.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stloyd hm I dont think ~
behaves this way for 0.x.x versions. thanks for pointing this out.
[payum] update up to stable version.
@makasim Please use your fork for your code and PRs not the official repository! |
@stloyd i don't understand what you mean, is @makasim doing commits directly to master? are not we all working on branches pushed to the main repo from our forks and doing PRs to the main repo? I don't think @makasim is doing anything different ... or maybe i am not noticing. Does he have access as owner in sylius repo? |
@cordoval I did not push to master (: but I have push access to sylius repository and I created the branch in the sylius main repo not in my fork. |
@makasim 👶 i have a friend who has repo access! wow, congrats! 👶 but shame on you for such use of main repo 👎 👶 but we forgive you as you are putting some work on it. |
This PR update payum related libs to stable 0.6.* versions.