Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[payum] update up to stable version. #462

Merged
merged 1 commit into from
Oct 26, 2013
Merged

Conversation

makasim
Copy link
Contributor

@makasim makasim commented Oct 25, 2013

This PR update payum related libs to stable 0.6.* versions.

"payum/payum-bundle": "0.6.*@dev",
"payum/paypal-express-checkout-nvp": "0.6.*@dev",
"payum/omnipay-bridge": "0.6.*@dev"
"payum/payum": "0.6.*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we perhaps should switch this to ~0.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cordoval it does not make much difference for 0.x.x versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makasim It quite does, because this allow only the 0.6 and maintance release for this while ~0.6 will also get the 0.7 and never till 1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stloyd hm I dont think ~ behaves this way for 0.x.x versions. thanks for pointing this out.

stloyd added a commit that referenced this pull request Oct 26, 2013
[payum] update up to stable version.
@stloyd stloyd merged commit cb45abd into master Oct 26, 2013
@stloyd stloyd deleted the payum-update-to-stable branch October 26, 2013 08:56
@stloyd
Copy link
Contributor

stloyd commented Oct 26, 2013

@makasim Please use your fork for your code and PRs not the official repository!

@cordoval
Copy link
Contributor

@stloyd i don't understand what you mean, is @makasim doing commits directly to master? are not we all working on branches pushed to the main repo from our forks and doing PRs to the main repo? I don't think @makasim is doing anything different ... or maybe i am not noticing. Does he have access as owner in sylius repo?

@makasim
Copy link
Contributor Author

makasim commented Oct 27, 2013

@cordoval I did not push to master (: but I have push access to sylius repository and I created the branch in the sylius main repo not in my fork.

@cordoval
Copy link
Contributor

@makasim 👶 i have a friend who has repo access! wow, congrats! 👶 but shame on you for such use of main repo 👎 👶 but we forgive you as you are putting some work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants