FIX-472 broken product form for cyrillic taxonomy

[asidorov01]

I replaced name to id, this is much more safe, because name could have non-latin character.

See #472

[cordoval]

no need to add the comment here, but i understand if it is just for autocomplete

[asidorov01]

this is for IDE, yes!

[cordoval]

👍 👶

[pjedrzejewski]

I think there is no better option than that for now, thanks Alex!

[winzou]

A better option wouldn't be to update the Urlizer::urlize method to support cyrillic?

[pjedrzejewski]

@winzou Or maybe using Doctrine extension slugizer? I think it handles Cyrillic?

[stloyd]

@pjedrzejewski If you think about Gedmo ones, this PR just replaced them, so I guess that it was not working as expected =)

@winzou My guess is that if pcre is not compiled with utf8 this will block that Urlizer as it depends on it (but it's guessing mostly =)).

[asidorov01]

Guys, it should use transliterator, and than use Urlizer.

So my first code was like $taxons[strtolower(Urlizer::transliterate((string)$taxonomy->getName()))] = array();
I think you kill me for that code, so I made this simpler with ids.

[pjedrzejewski]

Well, if it leaves us with more user-friendly ids, I don't think it's bad. @stloyd @winzou?

[stloyd]

@asidorov01 Your code looks (almost) acceptable (this in comment), I think that strtolower (but even if it's required it can be set as some variable & reused elsewhere) is not required there, same for (string) forcing as if getName() returns something different, there is problem with that code IMO.

@pjedrzejewski IIUC this PR adds (IIRC this in the html spec) not acceptable characters into id's/names in html markup, so it's not correct fix IMO.