Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Refactored AbstractCalculator #4864

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Apr 25, 2016

Q A
Bug fix? no
New feature? no
BC breaks? yes, in userland code (AbstractCalculator::calculate() made final)
Deprecations? no
Related tickets -
License MIT

@pjedrzejewski pjedrzejewski added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Apr 25, 2016
*/
protected function getParameterName()
{
return 'zone';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this should be zones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pamil pamil force-pushed the pricing/calculator-refactoring branch from c2a0561 to f94f2af Compare April 25, 2016 08:44
@pjedrzejewski pjedrzejewski merged commit 2c08017 into Sylius:master Apr 26, 2016
@pjedrzejewski
Copy link
Member

Thanks Kamil!

@pamil pamil deleted the pricing/calculator-refactoring branch April 26, 2016 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants