[TaxonomyBundle] Fix display bug in choice list and enlarge area #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@psyray I noticed this bug recently too, quite annoying! I think that proper fix would be on the query level (sort taxons properly), wdyt? |
|
I think the same thing before working on this PR, it's more elegant and a good practice to create a method in the Taxon repository. I will rework on it. |
|
Done ! |
|
Nice, thanks Raynald! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taxon choice list is badly sorted by id.
To keep tree consistent I've made this PR
My taxon list
Before PR
After PR
I've also enlarge the choice list height on product page, it's more readable whan you have a lot of taxons
Enjoy ;)