Use getRoot on taxons (replacing the remove getTaxonomy) #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coudenysj
commented
Jun 9, 2016
coudenysj
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | relates to #3773 |
| License | MIT |
|
Good catch, but I think we should use |
|
Makes sense. Updated the code. |
|
Thanks Jachim! 👍 |
|
There was already a fix for that in #5170. @coudenysj could you write spec for this method to prevent from regression in the future? |
|
Sorry @michalmarcinkowski & @h-sn, I wasn't aware of that. If @h-sn is willing to rebase then the test would still be his code. If not, I'm happy to supply the test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.