[Shop][Checkout] Sigining in during checkout addressing step #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arminek
force-pushed
the
new-shop-checkout-addressing-as-existing-customer
branch
from
f4cd5ab
to
6998339
Compare
Arminek
force-pushed
the
new-shop-checkout-addressing-as-existing-customer
branch
from
6998339
to
9fa38f1
Compare
Arminek
changed the title
| I want to be able to sign in and fill addressing details | ||
|
|
||
| Background: | ||
| Given the store operates on a single channel in "France" |
There was a problem hiding this comment.
Wrong indents here and below.
Arminek
force-pushed
the
new-shop-checkout-addressing-as-existing-customer
branch
3 times, most recently
from
cd9c63c
to
91ba4cf
Compare
| {{ form_row(form.customer.email) }} | ||
| <div class="one field" id="apiLogin"> | ||
| {{ form_row(form.customer.email) }} | ||
| <div class="ui action input" id="apiToggleable"> |
There was a problem hiding this comment.
This id is way too general.
Arminek
force-pushed
the
new-shop-checkout-addressing-as-existing-customer
branch
from
91ba4cf
to
9d9ee57
Compare
Arminek
force-pushed
the
new-shop-checkout-addressing-as-existing-customer
branch
from
9d9ee57
to
8960ba0
Compare
|
Thanks Arek, great work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create authentication handlers for Ajax signing in.