Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Generic login user type #5522

Merged
merged 2 commits into from Jul 20, 2016
Merged

[Behat] Generic login user type #5522

merged 2 commits into from Jul 20, 2016

Conversation

majidgolshadi
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets -
License MIT

@majidgolshadi
Copy link
Contributor Author

@pamil
All Sylius tests passed but Travic return The command "etc/travis/run-suite script "${SYLIUS_SUITE}"" exited with 255. error. WDYT?

@michalmarcinkowski
Copy link
Contributor

@majidgolshadi the build fails because of:

PHP Fatal error:  Declaration of Sylius\Behat\Service\SecurityService::performActionAs(Sylius\Component\User\Model\UserInterface $user, callable $action) must be compatible with Sylius\Behat\Service\SecurityServiceInterface::performActionAs(Sylius\Component\Core\Model\UserInterface $user, callable $action) in /home/travis/build/Sylius/Sylius/src/Sylius/Behat/Service/SecurityService.php on line 24

You should update this interface also.

@michalmarcinkowski michalmarcinkowski added the Behat Issues and PRs aimed at improving Behat usage. label Jul 19, 2016
@aramalipoor
Copy link
Contributor

👍 Ping @michalmarcinkowski ;)

@michalmarcinkowski michalmarcinkowski merged commit e4f4109 into Sylius:master Jul 20, 2016
@michalmarcinkowski
Copy link
Contributor

Thank you Majid!

@aramalipoor aramalipoor deleted the fix/login-user-type branch July 20, 2016 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Behat Issues and PRs aimed at improving Behat usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants