Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return event response for initialize update event #9019

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Return event response for initialize update event #9019

merged 1 commit into from
Apr 17, 2018

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Dec 11, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #8539
License MIT

@lchrusciel
Copy link
Member

I'm not sure about this change. It changes behaviour of resource controller and adds some logic only to update action. If we want to add it, similar change should be done to create action

@dannyvw
Copy link
Contributor Author

dannyvw commented Dec 23, 2017

Also added to the create action

@Zales0123 Zales0123 added Feature New feature proposals. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). and removed Feature New feature proposals. labels Jan 18, 2018
@pamil pamil added this to the 1.2 milestone Apr 17, 2018
@pamil pamil added the Feature New feature proposals. label Apr 17, 2018
@pamil pamil merged commit 8088304 into Sylius:master Apr 17, 2018
@pamil
Copy link
Contributor

pamil commented Apr 17, 2018

Thanks Danny, sorry for the delay! 🎉

@dannyvw dannyvw deleted the feature/initialize_event branch April 17, 2018 13:48
pamil added a commit to pamil/Sylius that referenced this pull request May 7, 2019
@pamil
Merge pull request Sylius#9019 from dannyvw/feature/initialize_event
078b580 
Return event response for initialize update event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Resource] Initialize event does not return response
4 participants
@dannyvw @lchrusciel @pamil @Zales0123